<html>
<head><meta charset="utf-8"><title>perf triage · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html">perf triage</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="205847449"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205847449" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205847449">(Aug 03 2020 at 21:05)</a>:</h4>
<p>Okay, I'll be conducting perf triage shortly</p>



<a name="205855370"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855370" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855370">(Aug 03 2020 at 22:36)</a>:</h4>
<p><span class="user-mention" data-user-id="120989">@njn</span> <a href="https://github.com/rust-lang/rustc-perf/blob/master/triage/2020-08-03.md">https://github.com/rust-lang/rustc-perf/blob/master/triage/2020-08-03.md</a></p>



<a name="205855388"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855388" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855388">(Aug 03 2020 at 22:36)</a>:</h4>
<p>I think we discussed that you'd do a similar pass over the data</p>



<a name="205855400"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855400" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855400">(Aug 03 2020 at 22:37)</a>:</h4>
<p>I used the just-added previous/next buttons on the compare.html pages</p>



<a name="205855536"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855536" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855536">(Aug 03 2020 at 22:38)</a>:</h4>
<p>(see arrows here: <a href="/user_uploads/4715/GOr4IyyohzxUKQAydVnw6t9b/image.png">image.png</a> )</p>
<div class="message_inline_image"><a href="/user_uploads/4715/GOr4IyyohzxUKQAydVnw6t9b/image.png" title="image.png"><img src="/user_uploads/4715/GOr4IyyohzxUKQAydVnw6t9b/image.png"></a></div>



<a name="205855550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855550">(Aug 03 2020 at 22:39)</a>:</h4>
<p>oh, that will indeed be useful</p>



<a name="205855568"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855568" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855568">(Aug 03 2020 at 22:39)</a>:</h4>
<p>I will go over it in the next hour or two, sound ok?</p>



<a name="205855579"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855579" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855579">(Aug 03 2020 at 22:39)</a>:</h4>
<p>yeah no worries, I might not look at all tonight again anyway</p>



<a name="205855592"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855592" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855592">(Aug 03 2020 at 22:39)</a>:</h4>
<p>the arrows pretty much guarantee we don't miss anything and we will also now show a warning if viewing non-adjacent commits</p>



<a name="205855598"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855598" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855598">(Aug 03 2020 at 22:40)</a>:</h4>
<p>well, we should get it into This Week in Rust today if possible</p>



<a name="205855645"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855645" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855645">(Aug 03 2020 at 22:40)</a>:</h4>
<p><a href="/user_uploads/4715/nCmOvfyXGAP0dm8D16Wy3vg7/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/nCmOvfyXGAP0dm8D16Wy3vg7/image.png" title="image.png"><img src="/user_uploads/4715/nCmOvfyXGAP0dm8D16Wy3vg7/image.png"></a></div>



<a name="205855667"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855667" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855667">(Aug 03 2020 at 22:40)</a>:</h4>
<p>ah okay, I can post a PR later tonight then</p>



<a name="205855672"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855672" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855672">(Aug 03 2020 at 22:40)</a>:</h4>
<p>just don't have investigative time probably</p>



<a name="205855684"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855684" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855684">(Aug 03 2020 at 22:40)</a>:</h4>
<p>you could post it now, the link won't change</p>



<a name="205855704"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855704" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855704">(Aug 03 2020 at 22:41)</a>:</h4>
<p><a href="https://github.com/emberian/this-week-in-rust/pull/1395">here</a> is an example TWiR PR, it's very simple</p>



<a name="205855851"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205855851" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205855851">(Aug 03 2020 at 22:43)</a>:</h4>
<p>ah true, will do that</p>



<a name="205856233"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205856233" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205856233">(Aug 03 2020 at 22:49)</a>:</h4>
<p><a href="https://github.com/emberian/this-week-in-rust/pull/1422">https://github.com/emberian/this-week-in-rust/pull/1422</a></p>



<a name="205856358"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205856358" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205856358">(Aug 03 2020 at 22:50)</a>:</h4>
<p>perf triage time was mostly taken up by linkifying and such in the triage report document, and now I'm feeling like I want something that'll basically do the hard work for me. Maybe I'll get bothered enough to write some code :)</p>



<a name="205856428"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205856428" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205856428">(Aug 03 2020 at 22:51)</a>:</h4>
<p>@simulacrum: you've listed <a href="https://github.com/rust-lang/rust/commit/76e83339bb619aba206e5590b1e4b813a154b199">76e83339bb619aba206e5590b1e4b813a154b199</a> as the starting revision, but it should really be <a href="https://github.com/rust-lang/rust/commit/efc02b03d18b0cbaa55b1e421d792f70a39230b2">efc02b03d18b0cbaa55b1e421d792f70a39230b2</a>, the previous revision, which was the end point for last week</p>



<a name="205856480"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205856480" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205856480">(Aug 03 2020 at 22:52)</a>:</h4>
<p>hm</p>



<a name="205856482"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205856482" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205856482">(Aug 03 2020 at 22:52)</a>:</h4>
<p>having said that, you caught a regression between those two revisions</p>



<a name="205856491"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205856491" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205856491">(Aug 03 2020 at 22:52)</a>:</h4>
<p>that regression is why I did not do so</p>



<a name="205856499"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205856499" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205856499">(Aug 03 2020 at 22:52)</a>:</h4>
<p>since it seems like efc was checked last week, right?</p>



<a name="205856518"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205856518" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205856518">(Aug 03 2020 at 22:52)</a>:</h4>
<p>well, the possibility of it, that is</p>



<a name="205856522"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205856522" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205856522">(Aug 03 2020 at 22:53)</a>:</h4>
<p>I guess it depends how you look at it</p>



<a name="205856576"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205856576" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205856576">(Aug 03 2020 at 22:54)</a>:</h4>
<p>happy to update -- I guess my way of looking at it is that both sides are inclusively commits we've checked</p>



<a name="205856614"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205856614" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205856614">(Aug 03 2020 at 22:54)</a>:</h4>
<p>in <em>this</em> triage</p>



<a name="205856649"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205856649" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205856649">(Aug 03 2020 at 22:54)</a>:</h4>
<p>if you enter 76e8 as the starting point at <a href="http://perf.rust-lang.org">perf.rust-lang.org</a> and look for regressions via the graph, you'll miss it</p>



<a name="205856775"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205856775" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205856775">(Aug 03 2020 at 22:56)</a>:</h4>
<p>yes, that is true</p>



<a name="205856821"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205856821" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205856821">(Aug 03 2020 at 22:57)</a>:</h4>
<p>I can update it</p>



<a name="205857017"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205857017" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205857017">(Aug 03 2020 at 22:59)</a>:</h4>
<p>done</p>



<a name="205857587"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205857587" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205857587">(Aug 03 2020 at 23:06)</a>:</h4>
<p>You missed this improvement: <a href="https://perf.rust-lang.org/compare.html?start=46cf80dc1a75ad27f67e79f73fec371a16762494&amp;end=12799ad60ca66b664699a0145f5ac5ccc399d4b8&amp;stat=instructions%3Au">https://perf.rust-lang.org/compare.html?start=46cf80dc1a75ad27f67e79f73fec371a16762494&amp;end=12799ad60ca66b664699a0145f5ac5ccc399d4b8&amp;stat=instructions%3Au</a></p>



<a name="205857615"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205857615" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205857615">(Aug 03 2020 at 23:06)</a>:</h4>
<p>Unless you ignored it because it was a smallish rustdoc-only change?</p>



<a name="205857630"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205857630" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205857630">(Aug 03 2020 at 23:07)</a>:</h4>
<p>I am amazed at how many merges landed in the past week</p>



<a name="205857634"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205857634" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205857634">(Aug 03 2020 at 23:07)</a>:</h4>
<p>I guess that's the new hardware really having an effect</p>



<a name="205857644"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205857644" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205857644">(Aug 03 2020 at 23:07)</a>:</h4>
<p>A few weeks ago there were only 12 landings in the entire week</p>



<a name="205857695"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205857695" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205857695">(Aug 03 2020 at 23:08)</a>:</h4>
<p>The left/right arrows are a real help, I had just been clicking on each point in the graph, but that wouldn't have worked this week, too many points</p>



<a name="205857696"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205857696" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205857696">(Aug 03 2020 at 23:08)</a>:</h4>
<p>(maybe we shouldn't link to the query details page for the -doc benchmarks since there's no data for those iiuc)</p>



<a name="205857849"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205857849" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205857849">(Aug 03 2020 at 23:11)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> Did you look at max-rss? It's so noisy that you really have to look at the graph to see meaningful changes. The gimli change was a clear regression: <a href="https://perf.rust-lang.org/compare.html?start=cfc572cae2d1fc381cce476b5c787fd7221af98c&amp;end=c058a8b8dc5dea0ed9b33e14da9e317e2749fcd7&amp;stat=max-rss">https://perf.rust-lang.org/compare.html?start=cfc572cae2d1fc381cce476b5c787fd7221af98c&amp;end=c058a8b8dc5dea0ed9b33e14da9e317e2749fcd7&amp;stat=max-rss</a></p>



<a name="205857859"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205857859" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205857859">(Aug 03 2020 at 23:11)</a>:</h4>
<p>That's probably the only meaningful one</p>



<a name="205859021"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205859021" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205859021">(Aug 03 2020 at 23:29)</a>:</h4>
<p><span class="user-mention" data-user-id="120989">@njn</span> I did not</p>



<a name="205859083"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205859083" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205859083">(Aug 03 2020 at 23:30)</a>:</h4>
<p>It would be worth adding a link to those results</p>



<a name="205859111"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205859111" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205859111">(Aug 03 2020 at 23:30)</a>:</h4>
<p>The rustdoc improvement I decided must be a result of underlying noise, i.e. std itself changing basically so we're doing less work or so.</p>



<a name="205859125"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205859125" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205859125">(Aug 03 2020 at 23:31)</a>:</h4>
<p>I can add the max RSS link in a bit</p>



<a name="205860539"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205860539" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205860539">(Aug 03 2020 at 23:57)</a>:</h4>
<p>added max-rss to gimli.</p>



<a name="205871004"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205871004" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205871004">(Aug 04 2020 at 03:48)</a>:</h4>
<p><span class="user-mention silent" data-user-id="120989">njn</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/perf.20triage/near/205857587">said</a>:</p>
<blockquote>
<p>You missed this improvement: <a href="https://perf.rust-lang.org/compare.html?start=46cf80dc1a75ad27f67e79f73fec371a16762494&amp;end=12799ad60ca66b664699a0145f5ac5ccc399d4b8&amp;stat=instructions%3Au">https://perf.rust-lang.org/compare.html?start=46cf80dc1a75ad27f67e79f73fec371a16762494&amp;end=12799ad60ca66b664699a0145f5ac5ccc399d4b8&amp;stat=instructions%3Au</a></p>
</blockquote>
<p>Wait, what? That second commit is bumping the version of libc, that shouldn't have anything to do with rustdoc perf</p>



<a name="205871018"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205871018" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205871018">(Aug 04 2020 at 03:49)</a>:</h4>
<p>I guess maybe the new version could have fewer dependencies so rustdoc loads fewer crates?</p>



<a name="205871070"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/perf%20triage/near/205871070" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/perf.20triage.html#205871070">(Aug 04 2020 at 03:50)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/perf.20triage/near/205859111">said</a>:</p>
<blockquote>
<p>The rustdoc improvement I decided must be a result of underlying noise, i.e. std itself changing basically so we're doing less work or so.</p>
</blockquote>
<p>Ah ok, that sounds about right. I was scrolled up <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>